http://www.ajaxeditcomments.com/forums/forum/themes Ajax Edit Comments Support Forums » Forum: Theme Issues - Recent Posts en-US Tue, 07 Sep 2010 22:19:43 +0000 http://bbpress.org/?v=1.0.2 q http://www.ajaxeditcomments.com/forums/search.php http://www.ajaxeditcomments.com/forums/topic/incompatible-with-thesis-17#post-434 Thu, 15 Jul 2010 19:17:19 +0000 Ronald Huereca 434@http://www.ajaxeditcomments.com/forums/ <p>Cool beans. Keep me posted. </p> http://www.ajaxeditcomments.com/forums/topic/incompatible-with-thesis-17#post-433 Thu, 15 Jul 2010 19:16:01 +0000 slobizman 433@http://www.ajaxeditcomments.com/forums/ <p>Thanks so much for working on this. I can't test it on my site now as I'm on 1.6 now. Your plugin is so important that I downgraded when I first realized it didn't work on 1.7. My users screamed.</p> <p>I'll probably go directly to 1.8 in a couple weeks. The beta is out and I suspect the final will be out shortly. </p> http://www.ajaxeditcomments.com/forums/topic/incompatible-with-thesis-17#post-432 Thu, 15 Jul 2010 17:50:18 +0000 Ronald Huereca 432@http://www.ajaxeditcomments.com/forums/ <p>Version 4.1.1 is out now with the changes. Please let me know if it works out for you. </p> http://www.ajaxeditcomments.com/forums/topic/incompatible-with-thesis-17#post-429 Thu, 15 Jul 2010 16:55:43 +0000 Ronald Huereca 429@http://www.ajaxeditcomments.com/forums/ <p>slobizman,</p> <p>Looks like I got it working locally. No biggie.</p> <p>Hope to release it today.</p> <p>A Thesis Rep (girlie) now has access to the forums, so perhaps you'll see something from her. However, I imagine Thesis has bigger fish to fry at the moment (re: GPL debate with Matt Mullenweg). </p> http://www.ajaxeditcomments.com/forums/topic/incompatible-with-thesis-17#post-428 Tue, 13 Jul 2010 17:03:45 +0000 slobizman 428@http://www.ajaxeditcomments.com/forums/ <p>Thanks. I posted your comment, and also mentioned in the thread that this is a must-have plugin. </p> http://www.ajaxeditcomments.com/forums/topic/incompatible-with-thesis-17#post-427 Tue, 13 Jul 2010 16:54:56 +0000 Ronald Huereca 427@http://www.ajaxeditcomments.com/forums/ <p>I don't mind. Theme's should accomodate plugins, not break them by design.</p> <p>I'll try to get something out no later than Thursday. I'll also see if there's an easier fix you can apply yourself to get the other comment plugins working. </p> http://www.ajaxeditcomments.com/forums/topic/incompatible-with-thesis-17#post-426 Tue, 13 Jul 2010 16:23:40 +0000 slobizman 426@http://www.ajaxeditcomments.com/forums/ <p>Do you mind if I post that on their forum in that thread, or would you prefer me not to?</p> <p>I hate to bug you, but do you have a guess as to when your next release will be?</p> <p>Thanks for the prompt reply. </p> http://www.ajaxeditcomments.com/forums/topic/incompatible-with-thesis-17#post-425 Tue, 13 Jul 2010 15:16:08 +0000 Ronald Huereca 425@http://www.ajaxeditcomments.com/forums/ <p>I'm a little peeved that the Thesis team broke a highly used WordPress hook and expect plugin authors to adhere to their (not WordPress' standards) for one theme.</p> <p>That being said, I'll put in the filters in the next release. </p> http://www.ajaxeditcomments.com/forums/topic/incompatible-with-thesis-17#post-424 Tue, 13 Jul 2010 12:59:02 +0000 slobizman 424@http://www.ajaxeditcomments.com/forums/ <p>It's me again. <img src='http://www.ajaxeditcomments.com/forums/my-plugins/bb-emoticons/smilies/icon_smile.gif' alt=':)' class='wp-smiley' /> </p> <p>Thesis 1.8 beta is out and I see that the "fix" is not implemented into it, so Ajax Edit Comments will not work with it. Your rememdy will make it work, but Thesis is saying it's not a good fix. Please take a look at this thread there:</p> <p><a href="http://diythemes.com/forums/showthread.php?p=151042" rel="nofollow">http://diythemes.com/forums/showthread.php?p=151042</a></p> <p>The last comment explains it best I think. They say I need to rite a filter, but that's getting a bit beyond my level. I hope you can address this so I can have the proper fix, and also tell other Thesis users about it. </p> <p>YOu might need to be logged in to Thesis. Just in case, here are the relevant posts:</p> <p>LAST POST:</p> <p><blockquote>I explained in post #2 why your proposed fix doesn't really make sense to implement based on how Thesis is actually coded - $output in that line of code does not only represent the comment's text; so applying a filter specifically for the comment text to a variable which may be producing something other than the comment text is not logical.</p> <p>Further, Thesis does not currently use WP's comment_text function at all; instead, it uses its own function, thesis_comment_text, and applies the appropriate WP filters to that.</p> <p>So (as I also explained in my previous post), if you need to enable support for a plugin which adds filters to comment_text, the way to do that for Thesis is by adding those same filters to thesis_comment_text in your custom_functions.php file.</p> <p>I can't identify the filters which Ajax Edit Comments applies to comment_text the way I could for Comment Rating, because it is a paid plugin and I do not have a copy of its source code. However, its developers should be able to tell you which filter(s) you need (i.e., the ones they are adding to comment_text); and then you can add them to thesis_comment_text in your custom_functions.php file. </blockquote></p> <p>Prior post:</p> <p><blockquote>Hmmm, $output in that line of code isn't limited to just the comment text - it's also used for the comment reply link (the second element available under Design Options &gt; Comment Options &gt; Comments &gt; Comment Body). Note the array just before that in the code:</p> <p>PHP Code:<br /> <code> $this-&gt;body = $thesis_design-&gt;comments['comments']['options']['body'];</p> <p> if (is_array($this-&gt;body)) {<br /> foreach ($this-&gt;body as $element_name =&gt; $element)<br /> if ($element['show']) $output .= call_user_func(array($this, $element_name), $comment);<br /> } </code><br /> So I don't think it would make sense to apply a filter specifically for comment_text to output which doesn't always represent the actual text of the comment.</p> <p>But Thesis has its own filter for the comment text, called here:</p> <p>PHP Code:<br /> <code> function text($comment) {<br /> $approved = ($comment['comment']-&gt;comment_approved == '0') ? '&lt;p class="comment_moderated"&gt;' . __('Your comment is awaiting moderation.', 'thesis') . "&lt;/p&gt;\n" : '';<br /> return $approved . apply_filters('thesis_comment_text', get_comment_text()); #filter<br /> } </code><br /> So, what I did was just find the filter that Comment Rating adds to comment_text, and added it to thesis_comment_text, with this in my custom_functions.php file:</p> <p>PHP Code:<br /> <code>add_filter('thesis_comment_text', 'ckrating_display_filter', 9000); </code><br /> and got this result (which, as you can tell by the checkmark indicating my rating, appears to have worked just fine):</blockquote> </p> http://www.ajaxeditcomments.com/forums/topic/incompatible-with-thesis-17#post-333 Mon, 17 May 2010 21:41:38 +0000 slobizman 333@http://www.ajaxeditcomments.com/forums/ <p>Thanks, I'll post it over at thesis. </p> http://www.ajaxeditcomments.com/forums/topic/incompatible-with-thesis-17#post-332 Mon, 17 May 2010 21:36:54 +0000 Ronald Huereca 332@http://www.ajaxeditcomments.com/forums/ <p>Yes, whatever your thesis directory looks like. Mine was wp-content/themes/thesis_17/lib/classes/comments.php </p> http://www.ajaxeditcomments.com/forums/topic/incompatible-with-thesis-17#post-330 Mon, 17 May 2010 21:29:14 +0000 slobizman 330@http://www.ajaxeditcomments.com/forums/ <p>You mean in the Thesis directory? </p> http://www.ajaxeditcomments.com/forums/topic/incompatible-with-thesis-17#post-329 Mon, 17 May 2010 21:27:06 +0000 Ronald Huereca 329@http://www.ajaxeditcomments.com/forums/ <p>Found the culprit.</p> <p>You'll have to modify /lib/classes/comments.php</p> <p>Around line 276 you'll see:<br /> <code>if ($output) echo $output;<br /> </code></p> <p>Change it to:<br /> <code>if ($output) echo apply_filters('comment_text',$output);</code> </p> http://www.ajaxeditcomments.com/forums/topic/incompatible-with-thesis-17#post-320 Sat, 15 May 2010 18:53:37 +0000 Ronald Huereca 320@http://www.ajaxeditcomments.com/forums/ <p>@slobizman,</p> <p>I'm getting a JavaScript error on line 15 from your site.</p> <p>I can help troubleshoot this, but I would need an admin account to your site to modify your header.php file of your theme.</p> <p>If interested, please send details to <a href="mailto:ronalfy@gmail.com">ronalfy@gmail.com</a>. </p> http://www.ajaxeditcomments.com/forums/topic/incompatible-with-thesis-17#post-317 Sat, 15 May 2010 13:16:36 +0000 besz 317@http://www.ajaxeditcomments.com/forums/ <p>Hi again! That's ok, and thanks for bringing this up! Checking into it now.... </p> http://www.ajaxeditcomments.com/forums/topic/incompatible-with-thesis-17#post-315 Sat, 15 May 2010 11:58:24 +0000 slobizman 315@http://www.ajaxeditcomments.com/forums/ <p>Sorry, the site is <a href="http://www.ihatethemedia.com">IHateThemedia.com</a> </p> http://www.ajaxeditcomments.com/forums/topic/incompatible-with-thesis-17#post-313 Sat, 15 May 2010 11:11:57 +0000 slobizman 313@http://www.ajaxeditcomments.com/forums/ <p>I upgraded Thesis 1.6 to 1.7 and the edit comments stuff under the comments is gone. On the Thesis website, I saw at least one other person who said they have the same problem. Considering there are so many Thesis users out there, perhaps you've got some information on this? Thanks. </p> http://www.ajaxeditcomments.com/forums/topic/buttons-not-showing-up#post-153 Fri, 05 Feb 2010 07:10:39 +0000 Pshemko 153@http://www.ajaxeditcomments.com/forums/ <p>I removed all the twitter piece of code. I don't need it.<br /> And now is working fine.</p> <p>Thanks a lot Ronalfy! </p> http://www.ajaxeditcomments.com/forums/topic/buttons-not-showing-up#post-152 Fri, 05 Feb 2010 07:00:01 +0000 Ronald Huereca 152@http://www.ajaxeditcomments.com/forums/ <p>Try this:</p> <p>In your "js.js" file, change line 53 from<br /> <code>username: twitterlogin,</code></p> <p>to your twitter username. Example:<br /> <code>username: &#39;ronalfy&#39;,</code> </p> http://www.ajaxeditcomments.com/forums/topic/buttons-not-showing-up#post-151 Fri, 05 Feb 2010 06:47:29 +0000 Pshemko 151@http://www.ajaxeditcomments.com/forums/ <p>Ok, techroom.pl </p> http://www.ajaxeditcomments.com/forums/topic/buttons-not-showing-up#post-149 Fri, 05 Feb 2010 06:34:13 +0000 Ronald Huereca 149@http://www.ajaxeditcomments.com/forums/ <p>@pshemko,</p> <p>I need a website to look at. Can you please provide? </p> http://www.ajaxeditcomments.com/forums/topic/buttons-not-showing-up#post-147 Fri, 05 Feb 2010 01:34:46 +0000 Pshemko 147@http://www.ajaxeditcomments.com/forums/ <p>Hi there,</p> <p>After upgrading to version 3.3, the edition buttons not showing up in posts and the panels.</p> <p>Thanks! </p>